ngn/anonymous_overflow
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Activity

feat: validate question id and send error messages

Browse Source
This commit is contained in:
httpjamesm 2022-12-29 13:45:04 -05:00
parent 3ff8e8cb96
commit e476087a3a
1 changed files with 40 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/routes/question.go
View File

@ -7,6 +7,7 @@ import (
"html/template" "html/template"
"os" "os"
"regexp" "regexp"
"strconv"
"strings" "strings"
"anonymousoverflow/src/types" "anonymousoverflow/src/types"
@ -23,13 +24,41 @@ func ViewQuestion(c *gin.Context) {
client := resty.New() client := resty.New()
questionId := c.Param("id") questionId := c.Param("id")
if len(questionId) < 8 {
c.HTML(400, "home.html", gin.H{
"errorMessage": "Invalid question ID",
"theme": c.MustGet("theme").(string),
})
return
}
if _, err := strconv.Atoi(questionId); err != nil {
c.HTML(400, "home.html", gin.H{
"errorMessage": "Invalid question ID",
"theme": c.MustGet("theme").(string),
})
return
}
questionTitle := c.Param("title") questionTitle := c.Param("title")
soLink := fmt.Sprintf("https://stackoverflow.com/questions/%s/%s", questionId, questionTitle) soLink := fmt.Sprintf("https://stackoverflow.com/questions/%s/%s", questionId, questionTitle)
resp, err := client.R().Get(soLink) resp, err := client.R().Get(soLink)
if err != nil { if err != nil {
panic(err) c.HTML(500, "home.html", gin.H{
"errorMessage": "Unable to fetch question data",
"theme": c.MustGet("theme").(string),
})
return
}
if resp.StatusCode() != 200 {
c.HTML(500, "home.html", gin.H{
"errorMessage": "Received a non-OK status code",
"theme": c.MustGet("theme").(string),
})
return
} }
respBody := resp.String() respBody := resp.String()
@ -38,7 +67,11 @@ func ViewQuestion(c *gin.Context) {
doc, err := goquery.NewDocumentFromReader(respBodyReader) doc, err := goquery.NewDocumentFromReader(respBodyReader)
if err != nil { if err != nil {
panic(err) c.HTML(500, "home.html", gin.H{
"errorMessage": "Unable to parse question data",
"theme": c.MustGet("theme").(string),
})
return
} }
newFilteredQuestion := types.FilteredQuestion{} newFilteredQuestion := types.FilteredQuestion{}
@ -55,7 +88,11 @@ func ViewQuestion(c *gin.Context) {
questionBodyParentHTML, err := questionBodyParent.Html() questionBodyParentHTML, err := questionBodyParent.Html()
if err != nil { if err != nil {
panic(err) c.HTML(500, "home.html", gin.H{
"errorMessage": "Unable to parse question body",
"theme": c.MustGet("theme").(string),
})
return
} }
newFilteredQuestion.Body = template.HTML(questionBodyParentHTML) newFilteredQuestion.Body = template.HTML(questionBodyParentHTML)