ngn/dumb
1
0
Fork 0
Code Issues 1 Pull Requests 3 Actions Packages Activity

remove lyrics header patch from upstream repo

Browse Source 
https://github.com/rramiachraf/dumb/pull/90

Signed-off-by: ngn <ngn@ngn.tf>
This commit is contained in:
ngn 2025-04-09 19:26:23 +03:00
parent 2a10f8bc2f
commit 1c8cd6ed32
Signed by: ngn
GPG Key ID: A3654DF5AD9F641D
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/lyrics.go
View File

@ -58,6 +58,8 @@ type customPerformance struct {
func (s *Song) parseLyrics(doc *goquery.Document) error { func (s *Song) parseLyrics(doc *goquery.Document) error {
var htmlError error var htmlError error
doc.Find("[class^=LyricsHeader]").Remove()
doc.Find("[data-lyrics-container='true']").Each(func(i int, ss *goquery.Selection) { doc.Find("[data-lyrics-container='true']").Each(func(i int, ss *goquery.Selection) {
h, err := ss.Html() h, err := ss.Html()
if err != nil { if err != nil {

7
handlers/lyrics_test.go
View File

@ -4,6 +4,7 @@ import (
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
"os" "os"
"strings"
"testing" "testing"
"github.com/PuerkitoBio/goquery" "github.com/PuerkitoBio/goquery"
@ -25,6 +26,7 @@ func TestLyrics(t *testing.T) {
func testLyrics(t *testing.T, url string) { func testLyrics(t *testing.T, url string) {
title := "The Silver Seas" title := "The Silver Seas"
artist := "Catch Yer Own Train" artist := "Catch Yer Own Train"
firstLyricLine := "[Verse 1]"
r, err := http.NewRequest(http.MethodGet, url, nil) r, err := http.NewRequest(http.MethodGet, url, nil)
if err != nil { if err != nil {
@ -46,6 +48,7 @@ func testLyrics(t *testing.T, url string) {
docArtist := doc.Find("#metadata-info h1").Text() docArtist := doc.Find("#metadata-info h1").Text()
docTitle := doc.Find("#metadata-info h2").Text() docTitle := doc.Find("#metadata-info h2").Text()
docLyrics := doc.Find("#lyrics").Text()
if docTitle != title { if docTitle != title {
t.Fatalf("expected %q, got %q\n", title, docTitle) t.Fatalf("expected %q, got %q\n", title, docTitle)
@ -54,4 +57,8 @@ func testLyrics(t *testing.T, url string) {
if docArtist != artist { if docArtist != artist {
t.Fatalf("expected %q, got %q\n", artist, docArtist) t.Fatalf("expected %q, got %q\n", artist, docArtist)
} }
if !strings.HasPrefix(docLyrics, firstLyricLine) {
t.Fatalf("expected lyrics to start with %q, got %q\n", firstLyricLine, docLyrics)
}
} }