fix(cache): make cache keys for review more distinctive

This commit is contained in:
zyachel
2024-03-31 17:21:35 +05:30
parent 1041de5439
commit 324c138ec4
5 changed files with 20 additions and 16 deletions

View File

@ -2,7 +2,7 @@ import type { NextApiRequest, NextApiResponse } from 'next';
import type { TitleReviewsCursored } from 'src/interfaces/shared/titleReviews';
import { cursoredReviews } from 'src/utils/fetchers/titleReviews';
import getOrSetApiCache from 'src/utils/getOrSetApiCache';
import { titleReviewsCursoredKey } from 'src/utils/constants/keys';
import { titleReviewsKey } from 'src/utils/constants/keys';
import { AppError, cleanQueryStr } from 'src/utils/helpers';
import { keys as titleReviewsQueryKeys } from 'src/utils/constants/titleReviewsFilters';
@ -19,7 +19,7 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
const queryObj = req.query as Record<string, string>;
const queryStr = cleanQueryStr(queryObj, titleReviewsQueryKeys);
const data = await getOrSetApiCache(
titleReviewsCursoredKey(titleId, paginationKey),
titleReviewsKey(titleId, queryStr, paginationKey),
cursoredReviews,
titleId,
paginationKey,

View File

@ -15,7 +15,12 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse<
const titleId = req.query.titleId as string;
const queryObj = req.query as Record<string, string>;
const queryStr = cleanQueryStr(queryObj, keys);
const data = await getOrSetApiCache(titleReviewsKey(titleId), reviews, titleId, queryStr);
const data = await getOrSetApiCache(
titleReviewsKey(titleId, queryStr, null),
reviews,
titleId,
queryStr
);
res.status(200).json({ status: true, data });
} catch (error: any) {
const { message = 'Not found', statusCode = 404 } = error;